feat: support tasks without commands #27191
Open
+62
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Dec 2, 2024
bartlomieju
reviewed
Dec 2, 2024
| @@ -446,7 +446,6 @@ | |||
| }, | |||
| "command": { | |||
| "type": "string", | |||
| "required": true, | |||
| "description": "The task to execute" | |||
There was a problem hiding this comment.
Can you update the description to mention that this field is required unless there's "dependencies" field specified?
There was a problem hiding this comment.
Is it required though? Having a task like this is valid in the string form:
{
"tasks": {
"foo": ""
}
}And I guess the same is also fine for the object notation:
{
"tasks": {
"foo": {}
}
}That's just a task that does nothing.
dsherret
approved these changes
Dec 3, 2024
bartlomieju
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running tasks that have no command and only dependencies. This is useful for when you want to group tasks only.
Fixes #27165